Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calling Tracer.notify_execution_start #531

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Conversation

rodiazet
Copy link
Collaborator

No description provided.

@rodiazet rodiazet requested a review from chfast November 25, 2022 18:23
@rodiazet rodiazet linked an issue Nov 25, 2022 that may be closed by this pull request
@rodiazet rodiazet force-pushed the 528-tracernotify_execution branch 2 times, most recently from 9676895 to 05554f5 Compare November 25, 2022 21:50
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #531 (ff67ad0) into master (fca591a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #531   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files          59       59           
  Lines        5687     5703   +16     
=======================================
+ Hits         5575     5591   +16     
  Misses        112      112           
Flag Coverage Δ
blockchaintests 77.97% <0.00%> (ø)
statetests 72.68% <0.00%> (ø)
unittests 91.74% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/evmone/baseline.cpp 100.00% <100.00%> (ø)
test/unittests/tracing_test.cpp 100.00% <100.00%> (ø)

@chfast chfast marked this pull request as ready for review November 28, 2022 10:46
@chfast chfast merged commit 9bdb915 into master Nov 28, 2022
@chfast chfast deleted the 528-tracernotify_execution branch November 28, 2022 11:25
@gumb0
Copy link
Member

gumb0 commented Dec 6, 2022

This broke EOF code tracing 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracer.notify_execution_start is called with truncated code
3 participants