Migrate benchmarks to the JSON State Test format #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles170
force-pushed
the
migrate-to-state-test
branch
from
33d9044
to
a93e10b
Compare
miles170
force-pushed
the
migrate-to-state-test
branch
2 times, most recently
from
0e16776
to
f965a83
Compare
chfast
reviewed
Oct 21, 2022
miles170
force-pushed
the
migrate-to-state-test
branch
2 times, most recently
from
66fce18
to
c68c2df
Compare
chfast
reviewed
Oct 21, 2022
miles170
force-pushed
the
migrate-to-state-test
branch
2 times, most recently
from
ab99342
to
439de19
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #513 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 54 54
Lines 5341 5344 +3
=======================================
+ Hits 5291 5294 +3
Misses 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Should I add more test cases to |
If you are asking in context of code coverage, then this is not needed. We don't run the tests yet. But on the other hand it is always welcomed to add new tests if you have any ideas. |
chfast
force-pushed
the
migrate-to-state-test
branch
from
439de19
to
b4c7a3c
Compare
chfast
force-pushed
the
migrate-to-state-test
branch
from
b4c7a3c
to
ec9e5ae
Compare
chfast
approved these changes
Oct 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #511.
I haven't checked gas used in every benchmark loop iteration because I want to make sure current changes won't break anything.
After that, I'll add a check for gas used.