Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pad code for EOF #508

Merged
merged 5 commits into from
Sep 30, 2022
Merged

Do not pad code for EOF #508

merged 5 commits into from
Sep 30, 2022

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 28, 2022

EOF does not require code padding for execution as executable code must end with terminating instruction.
This also refactors code analysis and execution state.

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #508 (53305d4) into master (9f4eef7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
- Coverage   99.41%   99.41%   -0.01%     
==========================================
  Files          53       54       +1     
  Lines        5264     5258       -6     
==========================================
- Hits         5233     5227       -6     
  Misses         31       31              
Flag Coverage Δ
blockchaintests 77.78% <56.52%> (-0.08%) ⬇️
statetests 7.58% <0.00%> (+0.01%) ⬆️
unittests 99.55% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/evmone/execution_state.hpp 94.54% <ø> (-0.20%) ⬇️
test/unittests/execution_state_test.cpp 100.00% <ø> (ø)
lib/evmone/baseline.cpp 100.00% <100.00%> (ø)
lib/evmone/baseline.hpp 100.00% <100.00%> (ø)
lib/evmone/instructions.hpp 100.00% <100.00%> (ø)

lib/evmone/baseline.cpp Outdated Show resolved Hide resolved
@chfast chfast merged commit 0897edb into master Sep 30, 2022
@chfast chfast deleted the analysis_executable_code branch September 30, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants