fuzzer: Correct the LICENSE #184
Conversation
It is not required, Apache 2.0 is compatible with GPL 3.0. This source still can be Apache licensed, but the resulting linked binary will be GPL 3.0. |
This seems right. Anyway, you suggest to remove changes in sources, but leave README and LICENSE? |
To simplify licensing in this repository I would suggest to keep everything under the same license (Apache 2.0) and mention in the fuzzer README that since aleth-interpreter is statically linked, the resulting fuzzer binary falls under the terms of GPL-3.0. |
|
It does not make sense yet. The evmone-fuzzer being a aleth-interepreter derived work, its source code must be released under GPL (Apache is compatible with GPL only in the other direction). |
Well it is a debatable case, hence why LGPL was created. The best would just linking dynamically through EVMC to both aleth-interpreter and evmone. |
The README file for evmone-fuzzer subproject explains the licensing when building with aleth-interpreter.
chfast
force-pushed
the
fuzzer_license
branch
from
012136c
to
366b51d
Compare
|
Better now? |
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 99.52% 99.64% +0.11%
==========================================
Files 5 5
Lines 839 839
Branches 109 109
==========================================
+ Hits 835 836 +1
+ Misses 1 0 -1
Partials 3 3 |
|
I think the argument here is that you link against EVMC which is Apache-2.0 and you are a "derived work" (but don't think Apache defines that as strictly as GPL) of that. Aleth-Interpreter also just implements that. |
|
I don't care much about it. I just didn't want to totally ignore the issue. |
Rename EVMC_LATEST_REVISION to EVMC_MAX_REVISION
Change the license of evmone-fuzzer from Apache 2.0 to GPL 3.0.
This is required because evmone-fuzzer "links to" aleth-interpreter (GPL 3.0).