Drop op_table parameter in analysis() #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 85.09% 85.04% -0.06%
==========================================
Files 21 21
Lines 2241 2240 -1
Branches 219 218 -1
==========================================
- Hits 1907 1905 -2
- Misses 307 308 +1
Partials 27 27 |
gumb0
reviewed
Sep 10, 2019
| } | ||
| (); | ||
|
|
||
| const auto& op_table = get_op_table(rev); |
There was a problem hiding this comment.
Danger of static init fiasco? in case op_tables in instructions.cpp is initialized after this
There was a problem hiding this comment.
The problem does not apply to constexpr globals, but still I can move it inside the function.
There was a problem hiding this comment.
Ah right, haven't noticed constexpr
gumb0
reviewed
Sep 10, 2019
| const exec_fn_table& fns, evmc_revision rev, const uint8_t* code, size_t code_size) noexcept; | ||
| evmc_revision rev, const uint8_t* code, size_t code_size) noexcept; | ||
|
|
||
| EVMC_EXPORT const exec_fn_table& get_op_table(evmc_revision rev) noexcept; |
There was a problem hiding this comment.
Used in analysis tests (evmone is usually built as shared library).
gumb0
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the
instruction_tableis more precise name, butop_tableis shorter and might be less mistaken with the table of instructions in the loaded program.