Drop the call kind runtime argument

[chfast]

No description provided.

[codecov-io]

Codecov Report

Merging #159 into master will decrease coverage by 4.11%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage    90.2%   86.09%   -4.12%     
==========================================
  Files          21       21              
  Lines        2246     2229      -17     
  Branches      220      220              
==========================================
- Hits         2026     1919     -107     
- Misses        196      283      +87     
- Partials       24       27       +3

[axic]

Is it such a big speed bump its worth the code duplication (in the binary)?

It doesn't matter for compiling to C, but it could if we actually manage compiling it to Wasm. However it is minor I suppose.

[axic]

Couldn't you merge delegatecall/staticcall into call now with if constexpr ?

[chfast]

This is only done for removing this additional immediate value. I don't have any benchmarks for calls. There is a way to de-duplicate the code again (and for all other calls) by using a proxy function. But I want to keep the information about the call kind effectively in the function pointer.

template <kind>
void op_call(...)
{
    op_call_impl(kind, ...);
}

[chfast]

Couldn't you merge delegatecall/staticcall into call now with if constexpr ?

I could if I had more time. #160

[chfast]

I'm merging this leaving the mentioned issues for later discussion and future work.