Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to LLVM 8 #187

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update to LLVM 8 #187

wants to merge 5 commits into from

Conversation

hydai
Copy link

@hydai hydai commented Jun 4, 2019

Close #182

Hi,
I've updated LLVM from 5.0.0 to 8.0.0. And I'm very interested in how to test evmjit. Is there any test suite?

@chfast
Copy link
Member

chfast commented Aug 8, 2019

I've updated LLVM from 5.0.0 to 8.0.0. And I'm very interested in how to test evmjit. Is there any test suite?

EVMJIT supports EVMC API so you can use testeth tool from Aleth project to test it. E.g. testeth -- --vm ./evmjit.so.

The problem is the EVMC version here is quite old and not ABI compatible with the latest EVMC 6. The EVMC would need to be upgraded here. You might also want to find some older binaries of Aleth or find a version of Aleth where EVMJIT was still includes as git submodule and then just update the submodule with this PR.

Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but without performing any functional tests it will be risky to merge this.

return false;
}

bool getUserCacheDir(llvm::SmallVectorImpl<char> &_result)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where these functions removed from LLVM?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These functions are removed in this PR: https://reviews.llvm.org/D52184

@hydai
Copy link
Author

hydai commented Aug 17, 2019

Thanks for reviewing this PR.
I am going to add functional tests to verify this PR.

@axic
Copy link
Member

axic commented Aug 17, 2019

@hydai perhaps you want to consider updating EVMC first to 6.3.0 and using evmone's evm-test to validate evmjit.

@hydai
Copy link
Author

hydai commented Aug 18, 2019

@axic Good idea. I am going to update EVMC and prepare the validation phase first.

@chfast
Copy link
Member

chfast commented Nov 11, 2019

I started investigating CI and LLVM 5.0 is hard to get for Ubuntu/Debian. LLVM 6.0 is the oldest version easily available. I think to make it easy we should either upgrade to LLVM 6.0 (minimal upgrade possible) or directly to 8 as in this PR.

@hydai
Copy link
Author

hydai commented Nov 12, 2019

I will check that the cost of upgrading to LLVM 6.0. If it's easy, then we just upgrade to LLVM 6.0 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to LLVM 6 (or 7 or 8)
3 participants