-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to LLVM 8 #187
base: master
Are you sure you want to change the base?
Update to LLVM 8 #187
Conversation
…m has removed this function
EVMJIT supports EVMC API so you can use testeth tool from Aleth project to test it. E.g. The problem is the EVMC version here is quite old and not ABI compatible with the latest EVMC 6. The EVMC would need to be upgraded here. You might also want to find some older binaries of Aleth or find a version of Aleth where EVMJIT was still includes as git submodule and then just update the submodule with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but without performing any functional tests it will be risky to merge this.
return false; | ||
} | ||
|
||
bool getUserCacheDir(llvm::SmallVectorImpl<char> &_result) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where these functions removed from LLVM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These functions are removed in this PR: https://reviews.llvm.org/D52184
Thanks for reviewing this PR. |
@axic Good idea. I am going to update EVMC and prepare the validation phase first. |
I started investigating CI and LLVM 5.0 is hard to get for Ubuntu/Debian. LLVM 6.0 is the oldest version easily available. I think to make it easy we should either upgrade to LLVM 6.0 (minimal upgrade possible) or directly to 8 as in this PR. |
I will check that the cost of upgrading to LLVM 6.0. If it's easy, then we just upgrade to LLVM 6.0 first. |
Close #182
Hi,
I've updated LLVM from 5.0.0 to 8.0.0. And I'm very interested in how to test evmjit. Is there any test suite?