Add EXPERIMENTAL revision #728
Conversation
chfast
force-pushed
the
rev_experimental
branch
2 times, most recently
from
101edf9 to
8ec1923
Compare
Add new `EVMC_EXPERIMENTAL` to `evmc_revision` to allow EVM implementations to expose experimental features.
chfast
force-pushed
the
rev_experimental
branch
from
8ec1923 to
54f43ed
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
==========================================
- Coverage 93.41% 93.39% -0.02%
==========================================
Files 26 26
Lines 3887 3892 +5
Branches 404 407 +3
==========================================
+ Hits 3631 3635 +4
Misses 140 140
- Partials 116 117 +1 |
| * The unspecified EVM revision used for EVM implementations to expose | ||
| * experimental features. | ||
| */ | ||
| EVMC_EXPERIMENTAL = 15, |
There was a problem hiding this comment.
So the number is going to change with every added revision? Then if somebody has this hardcoded, e.g. in the command line to evmc-tool, it will break... Maybe not a huge concern.
There was a problem hiding this comment.
I think in many places we use the fact that we have loop over revisions... I think it would be nice to have something like 100+, but I'm not sure I have time to investigate it right now.
There was a problem hiding this comment.
Yeah I guess it's mostly in tests, and it's not clear whether we would or would not want to include Experimental revision in them. Maybe rather we do want that, because experimental EVMs shouldn't break any existing functionality.
There was a problem hiding this comment.
Maybe if we put the EXPERIMENTAL outside of the MAX this would work somehow... but let's see first how this version works.
Add new
EVMC_EXPERIMENTALtoevmc_revisionto allow EVM implementations to expose experimental features.