cmake: Fix evmc_add_vm_test() not working in cross-compilation #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In add_test() use the evmc::evmc-vmtester target name directly to make it work with `CROSSCOMPILING_EMULATOR`.
|
Not sure if I should release this as EVMC 10.2. The |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #695 +/- ##
==========================================
+ Coverage 93.15% 93.18% +0.02%
==========================================
Files 25 25
Lines 3786 3800 +14
Branches 394 394
==========================================
+ Hits 3527 3541 +14
Misses 147 147
Partials 112 112 |
rodiazet
previously approved these changes
Sep 2, 2023
chfast
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In add_test() use the
evmc::evmc-vmtesterCMake target name directly to make it work withCROSSCOMPILING_EMULATOR.