C++: Rename evmc::result → evmc::Result #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Aug 10, 2022
| @@ -328,7 +328,7 @@ constexpr auto make_result = evmc_make_result; | |||
| /// | |||
| /// This is a RAII wrapper for evmc_result and objects of this type | |||
| /// automatically release attached resources. | |||
| class result : private evmc_result | |||
| class Result : private evmc_result | |||
There was a problem hiding this comment.
What is the reasoning behind this? Complex data types are upper case, simple data types (bytes32 for example) are lowercase?
There was a problem hiding this comment.
For consistency with evmc::VM, evmc::Host, evmc::HostInterface, etc. Not that we have perfect consistency but upper case names are easier to use in C++. @yperbasis was in favor.
gumb0
approved these changes
Aug 10, 2022
yperbasis
approved these changes
Aug 10, 2022
Rename the `evmc::result` to `evmc::Result` for consistency with C++ types of similar kind.
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
=======================================
Coverage 93.02% 93.02%
=======================================
Files 25 25
Lines 3655 3655
Branches 379 379
=======================================
Hits 3400 3400
Misses 145 145
Partials 110 110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the
evmc::resulttoevmc::Resultfor consistency with C++ types of similar kind.