hex: Add from_spaced_hex() #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the filter_iterator.hpp a public header of EVMC libraries.
Fix constness of operator!=, operator== of filter_iterator. This also silence the C++20 -Wambiguous-reversed-operator warning.
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
- Coverage 93.07% 93.04% -0.03%
==========================================
Files 25 25
Lines 3654 3654
Branches 378 379 +1
==========================================
- Hits 3401 3400 -1
Misses 144 144
- Partials 109 110 +1 |
gumb0
reviewed
Jun 3, 2022
include/evmc/filter_iterator.hpp
Outdated
| @@ -32,10 +33,19 @@ template <typename BaseIterator, | |||
| bool predicate(typename std::iterator_traits<BaseIterator>::value_type) noexcept> | |||
| struct filter_iterator | |||
| { | |||
| /// The iterators' difference type. | |||
There was a problem hiding this comment.
either iterator's or just iterator, make it consistent with comments below
There was a problem hiding this comment.
This was suppose to be "two iterators' difference type".
gumb0
reviewed
Jun 3, 2022
include/evmc/filter_iterator.hpp
Outdated
| constexpr void operator++() noexcept | ||
| { | ||
| ++base; | ||
| forward_to_next_value(); | ||
| } | ||
|
|
||
| constexpr bool operator!=(const filter_iterator& o) const noexcept { return base != o.base; } | ||
| /// The equal operator. |
There was a problem hiding this comment.
I think it should be "equality"/"inequality" operator
https://docs.microsoft.com/en-us/cpp/cpp/equality-operators-equal-equal-and-exclpt-equal?view=msvc-170
gumb0
reviewed
Jun 3, 2022
include/evmc/filter_iterator.hpp
Outdated
| @@ -83,6 +99,7 @@ struct skip_space_iterator : filter_iterator<BaseIterator, is_not_space> | |||
| using filter_iterator<BaseIterator, is_not_space>::filter_iterator; | |||
| }; | |||
|
|
|||
| /// CTAD. | |||
There was a problem hiding this comment.
a bit cryptic
Suggested change
| /// CTAD. | |
| /// Class template argument deduction guide. |
gumb0
approved these changes
Jun 3, 2022
gumb0
approved these changes
Jun 3, 2022
The from_spaced_hex() is from_hex() extension where the whitespace in the input is ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
from_spaced_hex()isfrom_hex()extension where the whitespace in the input is ignored.