Rename destination -> recipient #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
rename_destination
branch
from
203b639
to
f1a857a
Compare
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
==========================================
- Coverage 95.73% 95.73% -0.01%
==========================================
Files 24 24
Lines 3987 3986 -1
==========================================
- Hits 3817 3816 -1
Misses 170 170 |
chfast
force-pushed
the
rename_destination
branch
from
f1a857a
to
737093d
Compare
|
@chfast Shouldn't this merge be into the master branch? |
|
It's better to do the renaming in bindings/java/java/src/test/java/org/ethereum/evmc/TestMessage.java & EvmcTest.java as well. |
chfast
force-pushed
the
rename_destination
branch
2 times, most recently
from
56b81b9
to
d695ba5
Compare
yperbasis
approved these changes
Sep 8, 2021
chfast
force-pushed
the
rename_destination
branch
from
d695ba5
to
5766c9f
Compare
|
Should we test this in any downstream project? May be annoying in evmone's unit tests. |
|
I checked the change in evmone, and all required modification in evmone are purely mechanical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.