Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support London EIP-3198: BASEFEE opcode #603

Merged
merged 2 commits into from
May 28, 2021
Merged

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented May 26, 2021

Necessary facilities for EIP-3198, which is included into London hard fork.

@yperbasis yperbasis requested review from chfast, gumb0 and axic and removed request for chfast May 26, 2021 14:57
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #603 (13a0a9f) into master (da67705) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 13a0a9f differs from pull request most recent head d894522. Consider uploading reports for the commit d894522 to get more accurate results

@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
+ Coverage   95.68%   95.70%   +0.01%     
==========================================
  Files          24       24              
  Lines        3941     3954      +13     
==========================================
+ Hits         3771     3784      +13     
  Misses        170      170              

@yperbasis yperbasis added the changelog Deserves a CHANGELOG entry label May 26, 2021
@yperbasis yperbasis changed the title Support EIP-3198: BASEFEE opcode Support London EIP-3198: BASEFEE opcode May 26, 2021
@chfast chfast force-pushed the eip-3198 branch 2 times, most recently from 13a0a9f to b5c002e Compare May 28, 2021 12:46
@@ -76,6 +76,7 @@ type TxContext struct {
GasLimit int64
Difficulty Hash
ChainID Hash
BaseFee Hash // EIP-1559, EIP-3198
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep these comments here? If so, perhaps for the older ones (such as ChainID) too?

Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise.

@chfast chfast merged commit a55fd11 into ethereum:master May 28, 2021
@chfast chfast deleted the eip-3198 branch May 28, 2021 13:12
yperbasis added a commit to erigontech/evmone that referenced this pull request May 28, 2021
yperbasis added a commit to erigontech/silkworm that referenced this pull request May 28, 2021
yperbasis added a commit to erigontech/silkworm that referenced this pull request May 30, 2021
* EIP-3198: BASEFEE opcode

* Preliminary support for London consensus tests

* Revert to upstream evmc as ethereum/evmc/pull/603 is merged now

* Switch back to upstream evmone as ethereum/evmone/pull/333 is merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Deserves a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants