Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java: EvmcVm.close does not throw exception #579

Merged
merged 1 commit into from
Mar 22, 2021
Merged

java: EvmcVm.close does not throw exception #579

merged 1 commit into from
Mar 22, 2021

Conversation

axic
Copy link
Member

@axic axic commented Mar 22, 2021

Pulled out of #555.

@axic axic requested review from atoulme and chfast March 22, 2021 21:58
atoulme
atoulme approved these changes Mar 22, 2021
View reviewed changes
Copy link
Collaborator

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, important if implementing Closeable

@chfast chfast merged commit 4b4b95c into master Mar 22, 2021
@chfast chfast deleted the java-close-exception branch March 22, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@chfast chfast chfast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axic @atoulme @chfast