tools: Add --input option to evmc run
#564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Nov 3, 2020
|
|
||
| auto& run_cmd = *app.add_subcommand("run", "Execute EVM bytecode"); | ||
| run_cmd.add_option("code", code_hex, "Hex-encoded bytecode")->required(); | ||
| run_cmd.add_option("--vm", vm_config, "EVMC VM module")->required()->envname("EVMC_VM"); | ||
| run_cmd.add_option("--gas", gas, "Execution gas limit", true)->check(CLI::Range(0, 1000000000)); | ||
| run_cmd.add_option("--rev", rev, "EVM revision", true); | ||
| run_cmd.add_option("--input", input_hex, "Hex-encoded input bytes"); |
There was a problem hiding this comment.
I know it is common to name this input, but I think technically --calldata is a better choice as it reflects what it does.
There was a problem hiding this comment.
I'd go as far to propose we should rename it in the EVMC interface in with ABIv8.
There was a problem hiding this comment.
I think this is fine to rename it, but I see two issues:
- There is execution "output".
- In EVMC this will be
msg.calldata_data.
gumb0
approved these changes
Nov 13, 2020
chfast
force-pushed
the
tools_run_input
branch
from
44ed951
to
015bf93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.