java: statically load JNI library #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Oct 19, 2020
| private ByteBuffer nativeVm; | ||
|
|
||
| static { | ||
| System.loadLibrary("evmc-java"); |
There was a problem hiding this comment.
Instead of this, we need copy the shared library out of the JAR into some temporary directory and load from there. See #532 (comment)
Closed
axic
force-pushed
the
java-loader
branch
3 times, most recently
from
5007dea
to
f6fd869
Compare
|
Pulled in all the changes from #559. |
Also package both the JNI binding and the example VM in the JAR. Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
chfast
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should implement the pattern of storing the shared object in the JAR file, copying it to a temp folder, and loading it from there.