cpp: Add all comparison operators for address and bytes32 #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At this point, I think we should add all other comparison operators. |
chfast
force-pushed
the
cpp-operators
branch
3 times, most recently
from
32bde3f
to
6b4805f
Compare
This makes the types easier to use in outside APIs. Co-authored-by: Paweł Bylica <chfast@gmail.com>
chfast
changed the title
chfast
reviewed
Dec 5, 2019
| @@ -50,7 +50,6 @@ using uint256be = bytes32; | |||
| /// Loads 64 bits / 8 bytes of data from the given @p bytes array in big-endian order. | |||
| constexpr inline uint64_t load64be(const uint8_t* bytes) noexcept | |||
| { | |||
| // TODO: Report bug in clang incorrectly optimizing this with AVX2 enabled. | |||
There was a problem hiding this comment.
Reported and fixed: https://bugs.llvm.org/show_bug.cgi?id=42708
chfast
approved these changes
Dec 5, 2019
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.