Add mocked_host library #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Nov 18, 2019
chfast
force-pushed
the
mocked_host
branch
4 times, most recently
from
223517f
to
07b102f
Compare
gumb0
reviewed
Nov 20, 2019
gumb0
reviewed
Nov 20, 2019
gumb0
reviewed
Nov 20, 2019
gumb0
reviewed
Nov 20, 2019
axic
reviewed
Nov 21, 2019
axic
reviewed
Nov 21, 2019
| call_msg.input_data = input_copy.data(); | ||
| } | ||
| } | ||
| return result{call_result}; |
There was a problem hiding this comment.
If there is a single call_result it is not possible to deal with precompiles? Well, this function can be overriden. Have a look at the precompile stuff soltest is doing.
There was a problem hiding this comment.
This PR is for moving MockedHost from evmone. I will handle solidity later.
axic
approved these changes
Nov 21, 2019
Referencing EIP-2200 needs additional work to check its spec and it is still a draft. |
It takes the MockedHost implementation from evmone, converts it to C++11 and creates an interface library out of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It takes the MockedHost implementation from evmone and creates an interface library out of it.
Part of #447. Closes #334.