Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CREATE2 opcode in Constantinople #45

Merged
merged 3 commits into from
Jul 25, 2018
Merged

Support CREATE2 opcode in Constantinople #45

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc17468
Support CREATE2 opcode in Constantinople
gumb0 Jul 24, 2018
cac4f6f
CREATE2 support in instructions lib
gumb0 Jul 25, 2018
279f7c8
Add CREATE2 salt to evmc_message
gumb0 Jul 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/evmc/evmc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ enum evmc_call_kind
EVMC_CALL = 0, /**< Request CALL. */
EVMC_DELEGATECALL = 1, /**< Request DELEGATECALL. The value param ignored. */
EVMC_CALLCODE = 2, /**< Request CALLCODE. */
EVMC_CREATE = 3 /**< Request CREATE. Semantic of some params changes. */
EVMC_CREATE = 3, /**< Request CREATE. Semantic of some params changes. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the "Semantic of some params changes" part in both cases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should state which evmc_revision they are valid in (frontier, homestead, byzantium, constantinople).

EVMC_CREATE2 = 4 /**< Request CREATE2. Semantic of some params changes. */
};

/** The flags for ::evmc_message. */
Expand Down