Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks to C++ API #445

Merged
merged 3 commits into from
Nov 6, 2019
Merged

Tweaks to C++ API #445

merged 3 commits into from
Nov 6, 2019

Conversation

chfast
Copy link
Member

@chfast chfast commented Nov 6, 2019 •
edited
Loading

  • Add unit tests

@chfast chfast marked this pull request as ready for review November 6, 2019 12:32
@chfast chfast requested review from axic and gumb0 November 6, 2019 12:32
axic
axic approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but fails on lint.

@chfast chfast merged commit 85d22f0 into master Nov 6, 2019
@chfast chfast deleted the cpp branch November 6, 2019 19:09
@chfast chfast mentioned this pull request Nov 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

@gumb0 gumb0 gumb0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chfast @axic @gumb0