Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helpers: Return bool from is_abi_compatible() #442

Merged
merged 1 commit into from
Nov 5, 2019
Merged

helpers: Return bool from is_abi_compatible() #442

merged 1 commit into from
Nov 5, 2019

Conversation

chfast
Copy link
Member

@chfast chfast commented Nov 4, 2019

No description provided.

axic
axic approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evmc_account_exists_fn already returns a bool, so if there were any issues with it, we should have seen it.

@chfast
Copy link
Member Author

chfast commented Nov 5, 2019

evmc_account_exists_fn already returns a bool, so if there were any issues with it, we should have seen it.

Correct. The main evmc.h is using C _Bool / <stdbool.h> for some time. Also helpers.h is using bool in other places.

@chfast chfast merged commit bd65396 into master Nov 5, 2019
@chfast chfast deleted the helpers_tweak branch November 5, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

@gumb0 gumb0 Awaiting requested review from gumb0

@halfalicious halfalicious Awaiting requested review from halfalicious

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfast @axic