examples: implement support for passing accounts and copy_code #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Aug 8, 2019
examples/example_host.cpp
Outdated
| auto code = it->second.code; | ||
| if (code_offset >= code.size()) | ||
| return 0; | ||
| // TODO: implement this more nicely? |
There was a problem hiding this comment.
@chfast do you want to clear this up? 😉
axic
force-pushed
the
example-host-lib
branch
2 times, most recently
from
244c478
to
44b2cd4
Compare
chfast
reviewed
Oct 30, 2019
There was a problem hiding this comment.
Here is other copy_code() implementation: https://github.com/ethereum/evmone/blob/master/test/utils/host_mock.hpp#L190-L203.
examples/example_host.cpp
Outdated
| std::advance(begin, static_cast<long>(code_offset)); | ||
| auto len = std::distance(begin, end); | ||
| if (len > static_cast<long>(buffer_size)) | ||
| std::advance(end, len - static_cast<long>(buffer_size)); |
There was a problem hiding this comment.
This will advance it in the wrong direction (out of the vector). I think it is easier to use size instead of end in this case and in the end use std::copy_n().
examples/example_host.cpp
Outdated
| auto it = accounts.find(addr); | ||
| if (it == accounts.end()) | ||
| return 0; | ||
| auto code = it->second.code; |
There was a problem hiding this comment.
Suggested change
| auto code = it->second.code; | |
| auto& code = it->second.code; |
chfast
force-pushed
the
example-host-lib
branch
from
44b2cd4
to
db2e830
Compare
chfast
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #334.