Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp: Add vm::get_capabilities() method #301

Merged
merged 2 commits into from
May 29, 2019
Merged

cpp: Add vm::get_capabilities() method #301

merged 2 commits into from
May 29, 2019

Conversation

chfast
Copy link
Member

@chfast chfast commented May 29, 2019

Closes #265.

@chfast chfast requested a review from axic May 29, 2019 11:18
*
* The value returned might change when different options are requested via set_option.
* The value returned MAY change when different options are set via the set_option() method.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we could add a test for this? Does it make sense to add a test for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add behavior like that to example_vm but there is nothing to test here about conformance. Anyway, I'm going to remove this "feature" in EVMC 7.

@chfast chfast merged commit 89a4e8f into master May 29, 2019
@chfast chfast deleted the cpp_get_capabilities branch May 29, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add get_capabilities() method to EVMC C++
2 participants