Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmtester: do not crash if create_vm returns nullptr #234

Merged
merged 1 commit into from
Apr 24, 2019
Merged

vmtester: do not crash if create_vm returns nullptr #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/vmtester/vmtester.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ evmc_create_fn create_fn;
std::unique_ptr<evmc_instance, evmc_destroy_fn> create_vm()
{
auto vm = create_fn();
if (vm == nullptr)
return {nullptr, nullptr};
return {vm, vm->destroy};
Copy link
Member Author

@axic axic Apr 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vm->destroy derefs vm even if it is nullptr.

And there is a proper assertion we want to hit in this case: https://github.com/ethereum/evmc/blob/master/test/vmtester/vmtester.hpp#L21

}
} // namespace
Expand Down