chore: use href instead of deprecated to prop in InlineLink usage
#12278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enjoyooor
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
github-actions
bot
added
content 🖋️
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
cc @nhsz would love your 👀 |
minimalsm
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
LGTM, thanks @enjoyooor!
Just waiting on second review as it touches a lot.
|
@all-contributors please add @enjoyooor for code |
|
I've put up a pull request to add @enjoyooor! 🎉 |
pettinarip
requested changes
Mar 5, 2024
There was a problem hiding this comment.
Thanks for the refactor @enjoyooor. Everything looks good but there is one import condition that I don't think is necessary and shouldn't be included in the scope of this PR. LMK what do you think.
Comment on lines
+110
to
+113
| import { | ||
| default as uniswap, | ||
| default as uniswapec, | ||
| } from "@/public/dapps/uni.png" |
There was a problem hiding this comment.
I believe this is auto formatting according to eslint/prettier
There was a problem hiding this comment.
@pettinarip that is indeed an auto-fix from eslint, as it is the same image file imported twice. I guess eslint is unaware that it's an image file, so it consolidated the alias naming.
I'll look at throwing up a quick PR to address this duplication.
There was a problem hiding this comment.
Aha! didn't notice that, good call, thanks. Ok, so I guess we are ok then here 👍🏼
WalkthroughThe overall change across various components and pages involves updating the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (28)
- src/components/CommunityEvents/index.tsx (1 hunks)
- src/components/FileContributors.tsx (2 hunks)
- src/components/History/NetworkUpgradeSummary.tsx (2 hunks)
- src/components/Layer2/Layer2Onboard.tsx (2 hunks)
- src/components/Layer2ProductCard.tsx (1 hunks)
- src/components/MeetupList.tsx (1 hunks)
- src/components/RandomAppList.tsx (2 hunks)
- src/components/RollupProductDevDoc.tsx (2 hunks)
- src/components/StablecoinAccordion/index.tsx (4 hunks)
- src/components/Staking/StakingStatsBox.tsx (3 hunks)
- src/components/StatsBoxGrid/GridItem.tsx (1 hunks)
- src/components/TutorialMetadata.tsx (1 hunks)
- src/components/UpcomingEventsList.tsx (1 hunks)
- src/components/UpgradeBannerNotification.tsx (2 hunks)
- src/pages/assets.tsx (1 hunks)
- src/pages/contributing/translation-program/acknowledgements.tsx (2 hunks)
- src/pages/contributing/translation-program/contributors.tsx (2 hunks)
- src/pages/dapps.tsx (2 hunks)
- src/pages/developers/index.tsx (5 hunks)
- src/pages/developers/tutorials.tsx (1 hunks)
- src/pages/eth.tsx (3 hunks)
- src/pages/gas.tsx (1 hunks)
- src/pages/languages.tsx (3 hunks)
- src/pages/layer-2.tsx (7 hunks)
- src/pages/run-a-node.tsx (6 hunks)
- src/pages/stablecoins.tsx (5 hunks)
- src/pages/staking/deposit-contract.tsx (2 hunks)
- src/pages/what-is-ethereum.tsx (3 hunks)
Files not reviewed due to errors (1)
- (no review received)
Additional comments: 80
src/components/UpgradeBannerNotification.tsx (1)
- 15-15: The update from
totohrefin theInlineLinkcomponent aligns with the PR's objectives and modern HTML semantics. Good job on keeping the code clean and up-to-date.src/components/RandomAppList.tsx (1)
- 65-65: The update from
totohrefin theInlineLinkcomponent is correctly implemented. This change ensures the component's usage aligns with modern web standards.src/components/RollupProductDevDoc.tsx (3)
- 40-40: The prop update from
totohreffor thewebsitelink in theInlineLinkcomponent is correctly implemented, aligning with the PR's objectives.- 45-45: The prop update from
totohreffor thedeveloperDocslink in theInlineLinkcomponent is correctly implemented, ensuring the component's usage aligns with modern web standards.- 50-50: The prop update from
totohreffor thel2beatlink in theInlineLinkcomponent is correctly implemented. This change enhances the component's compatibility with current web practices.src/components/Layer2ProductCard.tsx (3)
- 86-86: The prop update from
totohreffor thebridgelink in theInlineLinkcomponent is correctly implemented, aligning with the PR's objectives.- 91-91: The prop update from
totohreffor theecosystemPortallink in theInlineLinkcomponent is correctly implemented, ensuring the component's usage aligns with modern web standards.- 96-96: The prop update from
totohreffor thetokenListslink in theInlineLinkcomponent is correctly implemented. This change enhances the component's compatibility with current web practices.src/components/History/NetworkUpgradeSummary.tsx (2)
- 54-54: The prop update from
totohreffor various links in theInlineLinkcomponent is correctly implemented, aligning with the PR's objectives and enhancing the component's compatibility with current web practices.- 100-100: The prop update from
totohreffor thewaybackLinkin theInlineLinkcomponent is correctly implemented. This change ensures the component's usage aligns with modern web standards.src/components/Staking/StakingStatsBox.tsx (3)
- 99-99: The prop update from
totohreffor theBeaconcha.inlink in theInlineLinkcomponent is correctly implemented, aligning with the PR's objectives and enhancing the component's compatibility with current web practices.- 110-110: The prop update from
totohreffor anotherBeaconcha.inlink in theInlineLinkcomponent is correctly implemented. This change ensures the component's usage aligns with modern web standards.- 121-121: The prop update from
totohreffor theBeaconcha.in/ethstorelink in theInlineLinkcomponent is correctly implemented. This change enhances the component's compatibility with current web practices.src/components/TutorialMetadata.tsx (1)
- 84-84: The prop update from
totohreffor the source link in theInlineLinkcomponent is correctly implemented, aligning with the PR's objectives and enhancing the component's compatibility with current web practices.src/components/UpcomingEventsList.tsx (1)
- 89-89: The prop update from
totohreffor the link to the community events JSON file in theInlineLinkcomponent is correctly implemented, aligning with the PR's objectives and enhancing the component's compatibility with current web practices.src/components/StatsBoxGrid/GridItem.tsx (1)
- 19-19: The prop update from
totohreffor the link to the metric's API provider in theInlineLinkcomponent is correctly implemented, aligning with the PR's objectives and enhancing the component's compatibility with current web practices.src/components/FileContributors.tsx (2)
- 63-63: The update from
totohreffor theInlineLinkcomponent aligns with the PR's objective to adhere to the updated component API. This change ensures that the link will function correctly with the new prop.- 150-150: The change from
totohreffor theInlineLinkcomponent usage here is consistent with the PR's goal and correctly updates the component to use the new prop. This ensures proper navigation functionality.src/pages/contributing/translation-program/contributors.tsx (2)
- 153-153: The update from
totohreffor theInlineLinkcomponent within theContributorscomponent is correctly implemented, aligning with the PR's objective to use the updated prop. This ensures the link will function as expected.- 181-181: This change from
totohreffor theInlineLinkcomponent is consistent with the PR's goal and correctly updates the component to use the new prop. It ensures the link will navigate correctly.src/components/CommunityEvents/index.tsx (1)
- 70-70: The change from
totohrefin theInlineLinkcomponent within theEventsubcomponent ofCommunityEventsis correctly implemented. This update aligns with the PR's objective and ensures the link will function as intended.src/pages/languages.tsx (3)
- 104-104: The update from
totohreffor theInlineLinkcomponent here correctly aligns with the PR's objective. This ensures that the link will function correctly with the new prop.- 111-111: This change from
totohreffor theInlineLinkcomponent is consistent with the PR's goal and correctly updates the component to use the new prop. It ensures the link will navigate correctly.- 206-206: The update from
totohreffor theInlineLinkcomponent in this context is correctly implemented, aligning with the PR's objective to use the updated prop. This ensures proper navigation functionality.src/components/StablecoinAccordion/index.tsx (3)
- 138-138: The change from
totohrefin theInlineLinkcomponent within theStablecoinAccordioncomponent is correctly implemented. This update aligns with the PR's objective and ensures the link will function as intended.- 227-227: This update from
totohreffor theInlineLinkcomponent is consistent with the PR's goal and correctly updates the component to use the new prop. It ensures the link will navigate correctly.- 251-251: The change from
totohreffor theInlineLinkcomponent here correctly aligns with the PR's objective. This ensures that the link will function correctly with the new prop.src/components/Layer2/Layer2Onboard.tsx (2)
- 238-238: The change from
totohreffor the link to "/bridges/" is correctly implemented and aligns with the PR objectives.- 261-261: The update from
totohreffor the link to "/wallets/find-wallet/" is correctly done, ensuring the component's usage is up to date with the latest standards.src/pages/contributing/translation-program/acknowledgements.tsx (1)
- 125-125: The replacement of
towithhreffor the link to "/contributing/translation-program/contributors/" is correctly implemented, aligning with the PR's objectives to updateInlineLinkusage.src/pages/gas.tsx (1)
- 263-263: The change from
totohrefin theInlineLinkusage aligns with modern web standards and improves link handling. Ensure that theInlineLinkcomponent is updated to correctly handle thehrefprop for navigation.src/pages/staking/deposit-contract.tsx (2)
- 354-354: The change from
totohrefin theInlineLinkusage aligns with modern web standards and improves link handling. Ensure that theInlineLinkcomponent is updated to correctly handle thehrefprop for navigation.- 481-481: The change from
totohrefin theInlineLinkusage aligns with modern web standards and improves link handling. Ensure that theInlineLinkcomponent is updated to correctly handle thehrefprop for navigation.src/pages/eth.tsx (6)
- 429-429: The change from
totohrefin theInlineLinkcomponent is correctly implemented here, aligning with the PR's objective to update deprecated prop usage.- 452-452: This instance of updating the
InlineLinkcomponent fromtotohrefis correctly done, ensuring the component's usage is up to date with the latest prop expectations.- 482-482: The replacement of the
toprop withhrefin thisInlineLinkcomponent is correctly applied, contributing to the consistency and modernization of the component's usage across the project.- 488-488: Correctly updated the
InlineLinkcomponent fromtotohref, which is in line with the PR's goal to replace deprecated prop usage.- 494-494: This change from
totohrefin theInlineLinkcomponent is properly implemented, ensuring the component adheres to the current prop usage standards.- 500-500: Successfully updated the
InlineLinkcomponent fromtotohref, maintaining the project's adherence to the latest component prop expectations.src/pages/developers/tutorials.tsx (1)
- 250-250: The change from
totohrefin theInlineLinkcomponent aligns with the PR's objective to update deprecated prop usage. This ensures compatibility with the component's expected behavior and adheres to current best practices.src/pages/developers/index.tsx (2)
- 258-258: The update from
totohrefin theInlineLinkcomponent is correctly implemented, ensuring the component's usage aligns with the latest standards.- 339-401: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [289-490]
All instances of
InlineLinkcomponents in this file have been correctly updated fromtotohref, following the PR's objective to replace the deprecated prop. This change is consistent across the file and improves the maintainability and future-proofing of the code.src/pages/assets.tsx (3)
- 163-163: The update from
totohrefin theInlineLinkcomponent usage aligns with the PR's objective to adhere to current best practices and the component's expected behavior. This change ensures proper navigation handling within theAssetsPagecomponent.- 168-168: Similar to the previous comment, this change correctly updates the
InlineLinkcomponent usage fromtotohref. It's consistent with the PR's goal and improves the link's accessibility and usability.- 173-173: This is another instance where the
InlineLinkcomponent's prop is updated fromtotohref, further ensuring that the application's navigation is handled correctly. The consistency in applying this change across different links in theAssetsPagecomponent is commendable.src/pages/layer-2.tsx (14)
- 325-325: The change from
totohrefin theInlineLinkcomponent is correctly implemented here. This aligns with the PR's objective to update the usage ofInlineLinkto reflect current best practices.- 361-361: The update from
totohrefin thisInlineLinkcomponent is correctly applied. It's important to ensure that the target URL is correctly formatted and accessible.- 442-442: This change correctly updates the
InlineLinkcomponent from usingtotohref. It's good practice to verify that the newhrefprop points to a valid and intended destination.- 580-580: The replacement of
towithhrefin theInlineLinkcomponent here is in line with the PR's objectives. Ensure that the link leads to the correct section or page as intended.- 585-585: Correctly updated the
InlineLinkcomponent fromtotohref. It's crucial to check that all links are functional and lead to the correct resources.- 635-635: The update from
totohrefin thisInlineLinkcomponent is correctly implemented. Always verify that the link is directing users to the correct and relevant information.- 640-640: This change from
totohrefin theInlineLinkcomponent is correctly applied. It's essential to ensure that the link is accurate and leads to the intended destination.- 656-656: The replacement of
towithhrefin theInlineLinkcomponent here is correctly done. Confirm that the link directs to the appropriate resource or page.- 664-664: Correctly updated the
InlineLinkcomponent fromtotohref. It's important to ensure that the link is functional and leads to the intended content.- 678-678: The change from
totohrefin theInlineLinkcomponent is correctly implemented here. Verify that the link points to the correct external resource.- 684-684: This update from
totohrefin theInlineLinkcomponent is correctly applied. Ensure that the link is directing users to the intended external resource.- 690-690: The replacement of
towithhrefin theInlineLinkcomponent here is in line with the PR's objectives. Confirm that the link leads to the correct YouTube video or resource.- 696-696: Correctly updated the
InlineLinkcomponent fromtotohref. It's crucial to verify that the link is functional and directs to the intended YouTube video or resource.- 702-702: This change from
totohrefin theInlineLinkcomponent is correctly implemented. Always ensure that the link points to the correct external article or resource.src/pages/stablecoins.tsx (5)
- 241-241: The change from
totohrefprop in theInlineLinkcomponent is correctly implemented here, aligning with the PR's objective to update the component usage according to the latest best practices. This ensures proper link behavior and enhances accessibility.- 427-427: The update from
totohreffor internal navigation links within theInlineLinkcomponent is correctly applied. This change is consistent with the PR's goal and improves the semantic correctness of the links.- 484-484: This modification from
totohrefin theInlineLinkcomponent is appropriate and follows the PR's intention to standardize link handling across the application. It's important to ensure that all internal links are correctly updated to maintain consistent navigation behavior.- 489-489: The change from
totohrefin theInlineLinkcomponent for internal navigation is correctly implemented. This adjustment is in line with the PR's objectives and contributes to the overall improvement of link accessibility and usability within the application.- 696-696: The conversion from
totohreffor theInlineLinkcomponent is correctly done here, aligning with the PR's goal to update deprecated prop usage. This change ensures that external links are handled correctly, enhancing the user experience.src/pages/what-is-ethereum.tsx (6)
- 298-298: The change from
totohrefprop in theInlineLinkcomponent is correctly implemented here. This aligns with the PR's objective to update the component usage according to the latest best practices.- 695-695: The change from
totohrefprop in theInlineLinkcomponent is correctly implemented here. This aligns with the PR's objective to update the component usage according to the latest best practices.- 702-702: The change from
totohrefprop in theInlineLinkcomponent is correctly implemented here. This aligns with the PR's objective to update the component usage according to the latest best practices.- 733-733: The change from
totohrefprop in theInlineLinkcomponent is correctly implemented here. This aligns with the PR's objective to update the component usage according to the latest best practices.- 739-739: The change from
totohrefprop in theInlineLinkcomponent is correctly implemented here. This aligns with the PR's objective to update the component usage according to the latest best practices.- 746-746: The change from
totohrefprop in theInlineLinkcomponent is correctly implemented here. This aligns with the PR's objective to update the component usage according to the latest best practices.src/pages/run-a-node.tsx (8)
- 547-547: The change from
totohrefin theInlineLinkcomponent is correctly implemented here, aligning with the PR's objective to update deprecated prop usage.- 826-826: The change from
totohrefin theInlineLinkcomponent is correctly implemented here, aligning with the PR's objective to update deprecated prop usage.- 833-833: The change from
totohrefin theInlineLinkcomponent is correctly implemented here, aligning with the PR's objective to update deprecated prop usage.- 838-838: The change from
totohrefin theInlineLinkcomponent is correctly implemented here, aligning with the PR's objective to update deprecated prop usage.- 882-882: The change from
totohrefin theInlineLinkcomponent is correctly implemented here, aligning with the PR's objective to update deprecated prop usage.- 893-893: The change from
totohrefin theInlineLinkcomponent is correctly implemented here, aligning with the PR's objective to update deprecated prop usage.- 902-902: The change from
totohrefin theInlineLinkcomponent is correctly implemented here, aligning with the PR's objective to update deprecated prop usage.- 911-911: The change from
totohrefin theInlineLinkcomponent is correctly implemented here, aligning with the PR's objective to update deprecated prop usage.src/pages/dapps.tsx (2)
- 117-120: The change to import
uni.pngusing ES6 destructuring syntax and assigning it touniswapanduniswapecis syntactically correct. This was confirmed to be an auto-fix by eslint due to the same image file being imported twice. The discussion in the PR comments provides additional context.- 1862-1862: Changing the
InlineLinkcomponent's attribute fromtotohrefaligns with the PR's objective to update the usage ofInlineLinkaccording to current best practices. This change is consistent with standard HTML semantics for links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dupe of #12218 (accidentally closed), prefer to contribute using my personal account
Noticed that the
toprop inInlineLinkcomponent is deprecated, so updating all usages to reflect this.Summary by CodeRabbit
New Features
Bug Fixes
toprops to standardhrefattributes, ensuring proper redirection and improving user navigation on the site.Refactor
Chores