Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: footer social buttons strange outline [Fixes #12213] #12223

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

AjayiMike
Copy link
Contributor

Description

To fix the weird social button outline, the margin has been removed from Icon component and added to the BaseLink component

Related Issue

[Fixes #12213]

Copy link

netlify bot commented Feb 17, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 0714968
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65d0e2a73e897f00089e818d
😎 Deploy Preview https://deploy-preview-12223--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AjayiMike AjayiMike changed the title fix: remove margin from the Icon component and add it to the BaseLink component [Fixes #12213] fix: footer social button strange outline [Fixes #12213] Feb 17, 2024
@AjayiMike AjayiMike changed the title fix: footer social button strange outline [Fixes #12213] fix: footer social buttons strange outline [Fixes #12213] Feb 17, 2024
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! thanks @AjayiMike!

@pettinarip pettinarip merged commit 124a42e into ethereum:dev Feb 19, 2024
6 checks passed
Copy link

gitpoap-bot bot commented Feb 19, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

This was referenced Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report: social button sizing
2 participants