add banner to community events page [fixes #11838] #12174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyg0
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
corwintines
requested changes
Feb 14, 2024
There was a problem hiding this comment.
Overall looks good @jennyg0!
One comment that needs fixing, then should be good to merge.
public/_redirects
Outdated
| /en/stablecoins /stablecoins 301! | ||
|
|
||
| /*/community/events https://esp.ethereum.foundation/devcon-grants 301! |
There was a problem hiding this comment.
Don't need the changes in this file. We still want people to land on the community events page on ethereum.org without redirecting. Just looking for the banner.
|
@all-contributors can you add @jennyg0 for code |
|
I've put up a pull request to add @jennyg0! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a dismissable banner on the Community Events page for "road to devcon grants".
Related Issue
fixes #11838
After: Page with Banner