-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: feedback widget by modifying left property #12052
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArianHamdi thanks again for the help on this.
The button is perfectly placed now and it doesn't create any horizontal overflow. However, when you click on the button and open the feedback popover, I see this:
It is not aligned with the button. Perhaps we need to apply the same left
prop in the popover container.
Yes, you are right, @pettinarip. This is the behavior currently observed on the website, and changing the If you want the dialog to render in the same position as the button, I will try to fix it too. |
Hi @pettinarip, Could you please check it again? I tried a workaround to align the popup position. Also, there was a bug that caused a horizontal jump when clicking on the button, but that has been fixed too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ArianHamdi!
This is working as expected now 💪🏼
FYI I'm creating a new PR #12135 to migrate the underlying component (AlertDialog) to a Popover since it is a better component to use in this case. Happy to have your eyes and feedback on that one as well if you are interested!
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Description
This PR prevent the appearance of a horizontal scrollbar wen hovering over the feedback widget.
Related Issue
Fixes: #12035