Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feedback widget by modifying left property #12052

Merged
merged 5 commits into from
Feb 8, 2024

Conversation

ArianHamdi
Copy link
Contributor

@ArianHamdi ArianHamdi commented Jan 30, 2024

Description

This PR prevent the appearance of a horizontal scrollbar wen hovering over the feedback widget.

Related Issue

Fixes: #12035

Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit ff1e34f
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65bc9897c2fbec000826a3e5
😎 Deploy Preview https://deploy-preview-12052--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ArianHamdi ArianHamdi closed this Jan 30, 2024
@github-actions github-actions bot added the abandoned This has been abandoned or will not be implemented label Jan 30, 2024
@ArianHamdi ArianHamdi reopened this Feb 1, 2024
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArianHamdi thanks again for the help on this.

The button is perfectly placed now and it doesn't create any horizontal overflow. However, when you click on the button and open the feedback popover, I see this:
image

It is not aligned with the button. Perhaps we need to apply the same left prop in the popover container.

@ArianHamdi
Copy link
Contributor Author

@ArianHamdi thanks again for the help on this.

The button is perfectly placed now and it doesn't create any horizontal overflow. However, when you click on the button and open the feedback popover, I see this: image

It is not aligned with the button. Perhaps we need to apply the same left prop in the popover container.

Yes, you are right, @pettinarip.

This is the behavior currently observed on the website, and changing the left property didn't produce it.

If you want the dialog to render in the same position as the button, I will try to fix it too.

@ArianHamdi
Copy link
Contributor Author

Hi @pettinarip,

Could you please check it again? I tried a workaround to align the popup position. Also, there was a bug that caused a horizontal jump when clicking on the button, but that has been fixed too.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArianHamdi!

This is working as expected now 💪🏼

FYI I'm creating a new PR #12135 to migrate the underlying component (AlertDialog) to a Popover since it is a better component to use in this case. Happy to have your eyes and feedback on that one as well if you are interested!

@pettinarip pettinarip merged commit 7067254 into ethereum:dev Feb 8, 2024
7 checks passed
Copy link

gitpoap-bot bot commented Feb 8, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

This was referenced Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned This has been abandoned or will not be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback Widget Causes Horizontal Scrolling
2 participants