New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add ERC-223 to token standards (closes #12004, #10854) #11787

Merged

corwintines merged 8 commits into ethereum:dev from Dexaran:dev

Jun 11, 2024

Contributor

Dexaran commented Dec 11, 2023

Description

Reverts #10841 as discussed with the maintainers earlier.

Related Issue

Dexaran added 5 commits

December 11, 2023 23:11


          Update index.md

c61adf5


          Create index.md

727804b


          Update index.md

3df37f9


          Update index.md

1187dbd


          Update developer-docs-links.yaml

f6b1e6c

Dexaran requested review from wackerow, corwintines, pettinarip, minimalsm and nhsz as code owners

December 11, 2023 19:17

netlify bot commented Dec 11, 2023 •

edited

Loading

✅ Deploy Preview for ethereumorg ready!

Name	Link
🔨 Latest commit	`924aef1`
🔍 Latest deploy log	https://app.netlify.com/sites/ethereumorg/deploys/6668a477a1ea2d00086771c3
😎 Deploy Preview	https://deploy-preview-11787--ethereumorg.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	7 paths audited Performance: 48 (🟢 up 10 from production) Accessibility: 92 (no change from production) Best Practices: 88 (🔴 down 4 from production) SEO: 93 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions bot added content 🖋️ review needed 👀 labels

Dexaran mentioned this pull request

Re-add ERC-223 to token standards. #10854

Closed

gorbatiukcom mentioned this pull request

Add ERC-223 token standard #12004

Closed

Contributor

github-actions bot commented May 8, 2024

This issue is stale because it has been open 30 days with no activity.

github-actions bot added the Status: Stale label

wackerow removed the needs review 👀 label

minimalsm reviewed

View reviewed changes

src/content/developers/docs/standards/tokens/erc-223/index.md Outdated Show resolved Hide resolved

minimalsm reviewed

View reviewed changes

src/content/developers/docs/standards/tokens/erc-223/index.md Outdated Show resolved Hide resolved

minimalsm reviewed

View reviewed changes

src/content/developers/docs/standards/tokens/erc-223/index.md Outdated Show resolved Hide resolved

minimalsm reviewed

View reviewed changes

src/content/developers/docs/standards/tokens/erc-223/index.md Outdated Show resolved Hide resolved

minimalsm reviewed

View reviewed changes

src/content/developers/docs/standards/tokens/erc-223/index.md Outdated Show resolved Hide resolved

minimalsm reviewed

View reviewed changes

src/content/developers/docs/standards/tokens/erc-223/index.md Outdated Show resolved Hide resolved

minimalsm reviewed

View reviewed changes

src/content/developers/docs/standards/tokens/erc-223/index.md Outdated Show resolved Hide resolved

minimalsm reviewed

View reviewed changes

src/content/developers/docs/standards/tokens/erc-223/index.md Outdated Show resolved Hide resolved

minimalsm reviewed

View reviewed changes

src/content/developers/docs/standards/tokens/erc-223/index.md Outdated Show resolved Hide resolved

minimalsm reviewed

View reviewed changes

src/content/developers/docs/standards/tokens/erc-223/index.md Outdated Show resolved Hide resolved

minimalsm reviewed

View reviewed changes

src/content/developers/docs/standards/tokens/erc-223/index.md Outdated Show resolved Hide resolved

minimalsm reviewed

View reviewed changes

src/content/developers/docs/standards/tokens/erc-223/index.md Outdated Show resolved Hide resolved

minimalsm reviewed

View reviewed changes

src/content/developers/docs/standards/tokens/erc-223/index.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

7344c18

minimalsm changed the title ~~Re-add ERC-223 to token standards.~~ Re-add ERC-223 to token standards (closes #12004, #10854)

minimalsm approved these changes

View reviewed changes

Contributor

minimalsm left a comment

LGTM after edits!

corwintines self-assigned this

corwintines added 2 commits

June 11, 2024 12:53


          Merge branch 'dev' into pr/Dexaran/11787

21f16f9


          fixes to get working on site

924aef1

github-actions bot added the tooling 🔧 label

corwintines approved these changes

View reviewed changes

corwintines merged commit e9351f3 into ethereum:dev

6 checks passed

gitpoap-bot bot commented Jun 11, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

wackerow mentioned this pull request

Warning regarding known ERC-20 problems #10889

Closed

2 tasks

This was referenced Jun 19, 2024

Release candidate v8.7.0 #13198

Merged

Deploy v8.7.0 #13204

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

minimalsm minimalsm approved these changes

corwintines corwintines approved these changes

wackerow Awaiting requested review from wackerow wackerow is a code owner

pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

nhsz Awaiting requested review from nhsz

Labels

content 🖋️ Status: Stale tooling 🔧