Update deposit data #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
reviewed
Mar 21, 2019
| @@ -5,7 +5,7 @@ | |||
| SECONDS_PER_DAY: constant(uint256) = 86400 | |||
| MAX_64_BIT_VALUE: constant(uint256) = 18446744073709551615 # 2**64 - 1 | |||
|
|
|||
| Deposit: event({data: bytes[528], merkle_tree_index: bytes[8]}) | |||
| Deposit: event({data: bytes[184], merkle_tree_index: bytes[8]}) | |||
There was a problem hiding this comment.
@JustinDrake @djrtwo @vbuterin do we want to fix the deposit data length tightly? I think allocating a bigger size is more future-proof.
There was a problem hiding this comment.
What is the gas impact either way?
There was a problem hiding this comment.
No impact if declared larger for future proof. More gas is charged only if there are more bytes to be logged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
ethereum/consensus-specs#780
How was it fixed?
deposit_timestampdeposit_inputto 176 bytesCute Animal Picture