Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create provenance.sol #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions provenance/provenance.sol
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
// provenance concept contract created by M.ElBoudi, A.Blackwell, M.Terzi et al during Ethereum development workshop in London

contract Certifiers {
mapping (address => bool) certifier;
address provenance;

//initialiser is run the first time the contract is uploaded to the network. Launched by Provenance and reads provenance "public key"
function Certifiers () {
provenance = msg.sender;
}

function createNewCertifier() returns (bool completed) {
certifier[msg.sender] = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I understand this correctly. Every key exists in a mapping from the beginning and is initialised to "zero", e.g. false for a bool. So this is more like resetCertify, i.e. it only reverses the effect of certify.

return true;
}

//if Provenance is launching the contract, then the entity becomes certified
function certify(address targetCertifier) returns (bool completed) {
if (provenance == msg.sender) {
certifier[targetCertifier] = true;
return true;
} else {
return false;
}
}
}

contract Producers{
struct meta{
bytes32 description;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it important to have this structure (description, phoneNumber, name) inside the contract? You could just use a string data, which will provide storage for a dynamically-sized string which can contain e.g. json-formatted data whose structure can be extended without changing the contract.

uint phoneNumber;
bytes32 name;
bool certified;
}
mapping (address => meta) producer;

function createProducer(bytes32 desc, uint phone, bytes32 name) returns (bool created) {
producer[msg.sender].description = desc;
producer[msg.sender].phoneNumber = phone;
producer[msg.sender].name = name;
producer[msg.sender].certified = false;
return true;
}
}

contract producerList{

mapping (address => bytes32) producerList;

function addProducer(bytes32 desc, uint phone, byte name) returns (bool completed) {
var producers = new Producers();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The address of the Producers is "lost" after the function returns. Is that intended?

return producers.createProducer(desc, phone, name);

}
}