Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After experimenting heavily with CI and generators, I decided it's better to keep generator triggering outside of CI for now.
What I experimented with:
venv
sReasons to not approach this further as of now:
Proposal to move forward:
make clean
)make -j 4 gen_yaml_tests
to run with 4 cores. Fixes to make this work + documentation included in this PR.<repo root>/eth2.0-spec-tests/tests
, with<repo root>/eth2.0-spec-tests/
being a git-ignored folder. It's easy to manage the output repo, re-build the tests in there.git add . && git commit -S -m "release foo bar" && git push
. You activate Git LFS once, and it just works.What we need after this:
eth2.0-spec-tests
repository, deprecating the oldeth2.0-tests
. We start fresh, with YAML files included using LFS, and a good amount of generators. The oldeth2.0-tests
is deprecated. The naming choice foreth2.0-spec-tests
comes from the nature of these tests: they all test spec-behavior. Later on, we may have agit lfs install
,git lfs track "*.yaml"
, and commit.gitattributes
README.md
,LICENSE