Custody punishments & period staggering Take 2 #934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dev: (108 commits) Update scripts/phase0/function_puller.py Update sync_protocol.md Update simple-serialize.md implement assertion sanity check suggested in PR fix argument typing for auxilary transition func Update test_generators/ssz/main.py Update test_libs/config_helpers/README.md Update test_generators/ssz/uint_test_cases.py Update test_generators/ssz/main.py Update test_generators/ssz/renderers.py Update test_generators/operations/deposits.py Update test_generators/operations/README.md Update test_generators/operations/README.md Update test_generators/README.md Update specs/test_formats/shuffling/README.md Update specs/test_formats/operations/deposits.md forks coverage description cleanup Update test_generators/README.md Update test_generators/README.md cleanup deposit tests ...
|
Would it make sense to just merge in the proposal to make the custody key be the RANDAO 2 periods in the future (#880) into this PR? So |
dankrad
reviewed
Apr 16, 2019
| @@ -251,7 +274,7 @@ def verify_custody_key(state: BeaconState, reveal: CustodyKeyReveal) -> bool: | |||
| signature=reveal.key, | |||
| domain=get_domain( | |||
| fork=state.fork, | |||
| epoch=reveal.period * EPOCHS_PER_CUSTODY_PERIOD, | |||
| epoch=reveal.period * EPOCHS_PER_CUSTODY_PERIOD + reveal.revealer_index % EPOCHS_PER_CUSTODY_PERIOD, | |||
There was a problem hiding this comment.
I think this is a mistake (no need to change this line)
# Conflicts: # specs/core/1_custody-game.md
|
I would suggest closing this in favour of #880, where I made an attempt to merge all the changes suggested here |
|
This has been incorporated into #880 and thus is no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following (and supersedes my previous attempt #872):
max_reveal_latenessis gradually reduced for timely responsesHereby items 6 and 8 from #864 are addressed.