use signed_root for block id purposes in blocks/state #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
requested review from
JustinDrake and
vbuterin
and removed request for
JustinDrake
JustinDrake
approved these changes
Mar 20, 2019
hwwhww
approved these changes
Mar 20, 2019
18 tasks
tersec
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Mar 21, 2019
tersec
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is directly to master. I would like to release this ASAP as a v0.5.1 release.
Addresses #797 by using
signed_rootwhen caching block headers in state and when assessing validity ofblock.previous_block_root.When discussing a blocks "hash" or "root" it should be considered as the
signed_root(block)to truncate off the signature which avoids an external dependency in the state transition function.