-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added FixedSizeList wrappers #777
Conversation
Requires corresponding changes to the spec pythonizer.
Should we go with |
I disagree with this notation. Many, if not the majority of, languages seem to deem |
That table is pretty cool. It looks like it's roughly 50/50 (what they call "init" and "heap" is a special case of fixed sized). |
Agreed. My point is more that the terminology may be ambiguous to users of certain languages. (A quick poll of the 3 CS majors in the room with me had them all declaring it to be dynamic. (I am aware this is not a strong argument)) |
If we want clarity, the name needs to evoke the property that actually make static and dynamic sized lists different. List vs tuple, array vs slice, list vs array all fail to do that. I'll keep thinking for better alternatives... |
Ideas: Mutable List vs Immutable list. Or appendable list vs fixed list. Or list vs vector. Honestly I think it's better to keep it simple and be clear in the definition of the type itself. |
If one-word-ness is a desideratum then list vs vector is definitely the least bad of what I've seen so far. |
+1 for list vs vector. Happy to rename "tuple" to "vector" in the SSZ spec. |
To be done in combination with #777. Also: * Define "fixed-size" and "variable-size" more rigorously * Use `"` vs `'` consistently * Add missing `"`
To be done in combination with #777. Also: * Define "fixed-size" and "variable-size" more rigorously * Use `"` vs `'` consistently * Add missing `"`
* Added FixedSizeList wrappers Requires corresponding changes to the spec pythonizer. * FixedSizeList -> Vector
To be done in combination with ethereum#777. Also: * Define "fixed-size" and "variable-size" more rigorously * Use `"` vs `'` consistently * Add missing `"`
Requires corresponding changes to the spec pythonizer.