Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SubnetID for sync committee #4076

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Use SubnetID for sync committee #4076

merged 1 commit into from
Jan 8, 2025

Conversation

ensi321
Copy link
Contributor

@ensi321 ensi321 commented Jan 7, 2025

SubnetID is being used for computing for attestation and blob subnets.

Updating sync committee subnet to use SubnetID type for consistency.

@ensi321 ensi321 mentioned this pull request Jan 7, 2025
Merged
ppopth
ppopth approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@ppopth ppopth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jtraglia
jtraglia approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. Thanks!

@jtraglia jtraglia merged commit d8650a9 into ethereum:dev Jan 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraglia jtraglia jtraglia approved these changes

@ppopth ppopth ppopth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ensi321 @ppopth @jtraglia