Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fork test with inactive, compounding validator with excess balance #4075

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Jan 7, 2025

This PR adds a test which will process a validator in the pre-activation loop and again in the compounding withdrawal credentials loop. If a client accidentally uses a stale list of validators, this should catch it. In that situation, there would be two pending deposits instead of one.

Fixes #4054.

Copy link
Contributor

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jtraglia jtraglia merged commit 4808c8d into ethereum:dev Jan 9, 2025
23 checks passed
@jtraglia jtraglia deleted the new-upgrade-to-electra-test branch January 9, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggested Electra test case
2 participants