Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to electra.BlobSidecar in EIP-7691 #4074

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Remove reference to electra.BlobSidecar in EIP-7691 #4074

merged 1 commit into from
Jan 8, 2025

Conversation

ensi321
Copy link
Contributor

@ensi321 ensi321 commented Jan 6, 2025

Removing reference to electra.BlobSidecar as there is no change to BlobSidecar's ssz type definition in Electra.

Alternatively we can define electra.BlobSidecar by defining MAX_BLOB_COMMITMENTS_PER_BLOCK_ELECTRA and KZG_COMMITMENT_INCLUSION_PROOF_DEPTH and revert changes to MAX_BLOB_COMMITMENTS_PER_BLOCK and KZG_COMMITMENT_INCLUSION_PROOF here.

jtraglia
jtraglia approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I prefer removing these over the alternative. Thank you!

ppopth
ppopth approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@ppopth ppopth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtraglia jtraglia merged commit 742115a into ethereum:dev Jan 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraglia jtraglia jtraglia approved these changes

@ppopth ppopth ppopth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ensi321 @ppopth @jtraglia