Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit correct block hash in random Electra tests #4072

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Emit correct block hash in random Electra tests #4072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/core/pyspec/eth2spec/test/utils/randomized_block_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from typing import Callable

from eth2spec.test.helpers.execution_payload import (
compute_el_block_hash,
compute_el_block_hash_for_block,
build_randomized_execution_payload,
)
from eth2spec.test.helpers.multi_operations import (
Expand Down Expand Up @@ -255,7 +255,7 @@ def random_block_deneb(spec, state, signed_blocks, scenario_state, rng=Random(34
opaque_tx, _, blob_kzg_commitments, _ = get_sample_blob_tx(
spec, blob_count=rng.randint(0, spec.config.MAX_BLOBS_PER_BLOCK), rng=rng)
block.body.execution_payload.transactions.append(opaque_tx)
block.body.execution_payload.block_hash = compute_el_block_hash(spec, block.body.execution_payload, state)
block.body.execution_payload.block_hash = compute_el_block_hash_for_block(spec, block)
block.body.blob_kzg_commitments = blob_kzg_commitments

return block
Expand All @@ -264,6 +264,7 @@ def random_block_deneb(spec, state, signed_blocks, scenario_state, rng=Random(34
def random_block_electra(spec, state, signed_blocks, scenario_state, rng=Random(3456)):
block = random_block_deneb(spec, state, signed_blocks, scenario_state, rng=rng)
block.body.execution_requests = get_random_execution_requests(spec, state, rng=rng)
block.body.execution_payload.block_hash = compute_el_block_hash_for_block(spec, block)

return block

Expand Down