Peerdas Change csc types to uint64 #3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
approved these changes
Sep 1, 2024
dapplion
approved these changes
Sep 2, 2024
Nashatyrev
reviewed
Sep 2, 2024
Nashatyrev
reviewed
Sep 2, 2024
hwwhww
approved these changes
Sep 2, 2024
g11tech
approved these changes
Sep 3, 2024
Co-authored-by: Anton Nashatyrev <Nashatyrev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3897
As discussed on discord:
Since ENRs are already rlp encoded, the csc field will get rlp encoded based on its size, so we can just keep it as a big endian integer value.
For metadata, I kept it as uint64 because its better to keep things consistent imo. And saving 6 bytes on metadata responses won't get us more than a couple hundred kilobytes savings per day which isn't significant