Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant copy() #3877

Merged
merged 1 commit into from
Aug 12, 2024
Merged

remove redundant copy() #3877

merged 1 commit into from
Aug 12, 2024

Conversation

fradamt
Copy link
Contributor

@fradamt fradamt commented Aug 9, 2024

pre_state is used in the Bellatrix spec, in is_merge_transition_block, but is unused in all other specs, other than to make a second copy of it, in state.

@fradamt fradamt requested a review from hwwhww August 9, 2024 08:53
@hwwhww hwwhww added the general:presentation Presentation (as opposed to content) label Aug 9, 2024
hwwhww
hwwhww approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you!

@hwwhww hwwhww merged commit d8cbca7 into ethereum:dev Aug 12, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
general:presentation Presentation (as opposed to content)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fradamt @hwwhww