Electra:EIP-7002/7251: clarify pending partial withdrawals handling #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ralexstokes
force-pushed
the
electra/restore-partial-withdrawals-handling
branch
from
b03381d to
2a81d0f
Compare
rolfyone
reviewed
Apr 16, 2024
hwwhww
changed the title
mkalinin
reviewed
Apr 17, 2024
hwwhww
approved these changes
Apr 17, 2024
mkalinin
reviewed
Apr 17, 2024
tests/core/pyspec/eth2spec/test/electra/unittests/test_config_invariants.py
Outdated
Show resolved
Hide resolved
mkalinin
reviewed
Apr 17, 2024
tests/core/pyspec/eth2spec/test/electra/unittests/test_config_invariants.py
Outdated
Show resolved
Hide resolved
prestonvanloon
approved these changes
Apr 17, 2024
|
update: after some discussion, we may only want to ensure that this value is less than the maximum number of withdrawals per payload and not necessarily exactly half, so ill remove the new invariant test I added im happy to keep discussing the name, although I still maintain the position that the name I suggested is more precise here |
ralexstokes
force-pushed
the
electra/restore-partial-withdrawals-handling
branch
3 times, most recently
from
c31ef61 to
21ed01c
Compare
ralexstokes
force-pushed
the
electra/restore-partial-withdrawals-handling
branch
from
21ed01c to
8213308
Compare
ralexstokes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renames constant and adjust value so we get the intended behavior so that pending partial withdrawals (from EL) can't block processing CL withdrawals