Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP-7549 to Electra #3653

Merged
merged 12 commits into from
Apr 9, 2024
Merged

Add EIP-7549 to Electra #3653

merged 12 commits into from
Apr 9, 2024

Conversation

ralexstokes
Copy link
Member

@ralexstokes ralexstokes commented Apr 5, 2024 •
edited
Loading

builds on top of #3615

rebased #3615 against dev @ f8cbd8d.

merges EIP-7549 into electra

TODO

@ralexstokes ralexstokes changed the title wip: rebase #3615 against dev WIP: add EIP-7549 to Electra Apr 5, 2024
@ralexstokes ralexstokes force-pushed the init-electra-rebase branch 2 times, most recently from 974ca28 to 8e2ec46 Compare April 5, 2024 17:36
@ralexstokes ralexstokes force-pushed the init-electra-rebase branch 3 times, most recently from a8aab51 to 23f60d0 Compare April 5, 2024 17:43
@ralexstokes ralexstokes changed the title WIP: add EIP-7549 to Electra Add EIP-7549 to Electra Apr 5, 2024
@ralexstokes ralexstokes marked this pull request as ready for review April 5, 2024 17:55
@ralexstokes ralexstokes force-pushed the init-electra-rebase branch from 23f60d0 to 1199ecf Compare April 5, 2024 19:19
@ralexstokes ralexstokes force-pushed the init-electra-rebase branch from 1199ecf to e4068b5 Compare April 5, 2024 19:57
@ralexstokes ralexstokes force-pushed the init-electra-rebase branch from ea79d11 to d35b409 Compare April 5, 2024 20:38
@ralexstokes ralexstokes requested review from hwwhww and dapplion April 6, 2024 23:46
@g11tech g11tech mentioned this pull request Apr 8, 2024
Merged
dapplion
dapplion reviewed Apr 9, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
hwwhww
hwwhww reviewed Apr 9, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
hwwhww
hwwhww approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re: Attestation types

I want to see further discussion at ACD and more analysis. But for the initial Electra interop, I think it's okay to start with the "do nothing" path for now.

The PR looks good to me!

@hwwhww hwwhww merged commit 483bafa into ethereum:dev Apr 9, 2024
28 checks passed
@ralexstokes ralexstokes deleted the init-electra-rebase branch April 9, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech left review comments

@dapplion dapplion dapplion left review comments

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
Electra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ralexstokes @hwwhww @dapplion @g11tech