-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-7251: misc changes #3636
EIP-7251: misc changes #3636
Conversation
This reverts commit 6f5cc4b.
I haven't gone through the changes, but the summary sounds good from a high-level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
||
return | ||
|
||
has_sufficient_effective_balance = validator.effective_balance == MIN_ACTIVATION_BALANCE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has_sufficient_effective_balance = validator.effective_balance == MIN_ACTIVATION_BALANCE | |
has_sufficient_effective_balance = validator.effective_balance >= MIN_ACTIVATION_BALANCE |
Co-authored-by: fradamt <104826920+fradamt@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! I lean towards merging (and ill make an issue for one comment l left, either I don't understand how the new partial withdrawals work or there is a bug...) and then ill make a testing pass in #3648
Summary of changes:
set_compounding_withdrawal_credentials
as it is unusedFULL_EXIT_REQUEST_AMOUNT
which is set to0
validator.effective_balance == MIN_ACTIVATION_BALANCE
check to partial withdrawalsThis check is borrowed from the sweep checks. Although, satisfying this condition with partial withdrawal is not as critical as with the sweep, re-gaining the min activation balance sooner should be aligned with interest of stakers and network
process_execution_layer_withdraw_request
validator.effective_balance
for consolidation churn to align its logic with the exit churn and with the churn limit computation which is EB basedprocess_execution_layer_withdraw_request
flow