You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a config field for the electra fork. The fork hasn't been finalized yet, but we are using the name as a placeholder on the testing stack to trigger the next fork (E.g, for IL testnets, ELECTRA_FORK_EPOCH would trigger the IL related EIPs).
Some CLs throw errors on startup if a config contains an undefined value. Adding ELECTRA_FORK_* to the official config list would ensure that even if the fork is never activated, atleast the clients wouldn't crash on startup and it sets us up for when the Electra fork is defined officially.
Potential discussion point: Do we still need EIP6110_FORK_VERSION/etc defined specifically? Can we remove them as they're scheduled for inclusion in ELECTRA* or are they still needed for some other layer of the testing stack?
Potential discussion point: Do we still need EIP6110_FORK_VERSION/etc defined specifically? Can we remove them as they're scheduled for inclusion in ELECTRA* or are they still needed for some other layer of the testing stack?
Right, so it should be cleaned up in #3615. I think #3615 will be open for a while for review. In the meantime, I think it's good to merge this PR to solve the issues you are facing. 👍
Potential discussion point: Do we still need EIP6110_FORK_VERSION/etc defined specifically? Can we remove them as they're scheduled for inclusion in ELECTRA* or are they still needed for some other layer of the testing stack?
Right, so it should be cleaned up in #3615. I think #3615 will be open for a while for review. In the meantime, I think it's good to merge this PR to solve the issues you are facing. 👍
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a config field for the
electrafork. The fork hasn't been finalized yet, but we are using the name as a placeholder on the testing stack to trigger the next fork (E.g, for IL testnets,ELECTRA_FORK_EPOCHwould trigger the IL related EIPs).Some CLs throw errors on startup if a config contains an undefined value. Adding
ELECTRA_FORK_*to the official config list would ensure that even if the fork is never activated, atleast the clients wouldn't crash on startup and it sets us up for when the Electra fork is defined officially.Potential discussion point: Do we still need
EIP6110_FORK_VERSION/etc defined specifically? Can we remove them as they're scheduled for inclusion inELECTRA*or are they still needed for some other layer of the testing stack?