Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deneb: Suggest sidecars by root callers verify blob sidecars #3535

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

ralexstokes
Copy link
Member

Suggest readers of BlobSidecarsByRoot also verify KZG proofs of blob data.

Suggest readers of `BlobSidecarsByRoot` also verify KZG proofs of blob data.
@ppopth
Copy link
Member

ppopth commented Oct 29, 2023

Looks good to me

@djrtwo
Copy link
Contributor

djrtwo commented Oct 29, 2023

@jtraglia was wondering why this wasn't explicitly there but was in the byRange request

I believe it's not explicitly here because you always have the block when doing this byRoot request. So you can put each message that comes in, into whatever validation workflow you want in relation to the block as you pull them down

Whereas in byRange, you might be syncing blocks and sidecars at the same time and not necessarily have the related block so there is an explicit SHOULD because you can't for-sure do it.

That said -- It's fine to put that in here explicitly to just point out to the reader that this isn't a bad option as an early validation to know if you're dealing with a correct peer or not

@hwwhww hwwhww added scope:networking Deneb was called: eip-4844 labels Oct 31, 2023
@djrtwo djrtwo merged commit 4e5599f into dev Oct 31, 2023
13 checks passed
@djrtwo djrtwo deleted the ralexstokes-patch-3 branch October 31, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deneb was called: eip-4844 scope:networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants