Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assert from is_data_available #3404

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Remove assert from is_data_available #3404

merged 1 commit into from
Jun 7, 2023

Conversation

mkalinin
Copy link
Contributor

@mkalinin mkalinin commented Jun 7, 2023 •
edited
Loading

I think this function should return false rather than throwing an AssertionError when blobs fail to pass the validation

@mkalinin mkalinin requested a review from hwwhww June 7, 2023 06:01
hwwhww
hwwhww approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hwwhww hwwhww merged commit 54c2c15 into dev Jun 7, 2023
@hwwhww hwwhww deleted the mkalinin-patch-2 branch June 7, 2023 09:04
This was referenced Jun 9, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkalinin @hwwhww