Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compute_quotient_eval_within_domain overflow #3256

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Fix compute_quotient_eval_within_domain overflow #3256

merged 1 commit into from
Feb 17, 2023

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Feb 16, 2023

Found in #3255

Test case:

cd tests/core/pyspec
pytest eth2spec/test/deneb/unittests/polynomial_commitments/test_polynomial_commitments.py::test_compute_kzg_proof_within_domain --preset=mainnet

for i, z in enumerate(roots_of_unity_brp) is 4096 iterations. My miserable laptop still couldn't run through this test case with the mainnet preset.

@hwwhww hwwhww added the Deneb was called: eip-4844 label Feb 16, 2023
@hwwhww hwwhww requested review from asn-d6 and dankrad February 16, 2023 17:27
@hwwhww hwwhww mentioned this pull request Feb 16, 2023
Merged
@hwwhww hwwhww added the general:bug Something isn't working label Feb 16, 2023
@hwwhww hwwhww merged commit 270a66e into dev Feb 17, 2023
@hwwhww hwwhww deleted the fix-compute_quotient_eval_within_domain branch February 17, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dankrad dankrad dankrad approved these changes

@asn-d6 asn-d6 Awaiting requested review from asn-d6

Assignees
No one assigned
Labels
Deneb was called: eip-4844 general:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwwhww @dankrad