Add block_to_light_client_header helper
#3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `block_to_light_client_header` helper function to enable future forks to override it with additional info (e.g., execution), without having to change the general light client logic. Likewise, update existing light client data creation flow to use `block_to_light_client_header` and default-initialize empty fields. Furthermore, generalize `create_update` helper to streamline test code using `block_to_light_client_header`. Note: In Altair spec, LC header is the same as `BeaconBlockHeader`. however; future forks will extend it with more information.
hwwhww
approved these changes
Dec 13, 2022
Comment on lines
-133
to
-141
| return LightClientUpdate( | ||
| attested_header=attested_header, | ||
| next_sync_committee=next_sync_committee, | ||
| next_sync_committee_branch=next_sync_committee_branch, | ||
| finalized_header=finalized_header, | ||
| finality_branch=finality_branch, | ||
| sync_aggregate=block.message.body.sync_aggregate, | ||
| signature_slot=block.message.slot, | ||
| ) |
There was a problem hiding this comment.
I feel the old return LightClientUpdate(...) is more mistake-proofing, i.e., less likely to miss one field. However, I like how your refactoring reduced the variables. 👍
Comment on lines
-129
to
-131
| else: | ||
| finalized_header = BeaconBlockHeader() | ||
| finality_branch = [Bytes32() for _ in range(floorlog2(FINALIZED_ROOT_INDEX))] |
There was a problem hiding this comment.
Note to reviewers: removed because they are the default value of update.finalized_header and update.finality_branch.
|
Anything still blocking on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
block_to_light_client_headerhelper function to enable future forks to override it with additional info (e.g., execution), without having to change the general light client logic.Likewise, update existing light client data creation flow to use
block_to_light_client_headerand default-initialize empty fields.Furthermore, generalize
create_updatehelper to streamline test code usingblock_to_light_client_header.Note: In Altair spec, LC header is the same as
BeaconBlockHeader. however; future forks will extend it with more information.