-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty blobs and commitments #3093
Conversation
- Put the code related to computing challenges in another method - remove panic on poly_lincomb() when `polys` is empty
Pushed two commits that resolve the linter error and add an assert here: https://github.com/asn-d6/consensus-specs/tree/pr_3093 All in all, I think the changes are sensible. Given the details of this special case, I'd like to do another review pass (probably early next week). Also, it would be great if @dankrad could take a look. |
Merged changes into the branch to update ci |
@kevaundray the CI errors happend at:
|
…luation challenge
21d5b28
to
d4c6a69
Compare
059c286
to
73adfa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me. I think it's much more natural than to have network messages with the absence of a SideCar
Co-authored-by: dankrad <mail@dankradfeist.de>
3110a8c
to
946fd5f
Compare
Empty blobs and commitments currently cause a panic.
This PR aims to handle this particular edge case.